Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2080)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding better comment from Charlie. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index aba8e8da4144695286229d967bdff63271bb2e09..e17bfa10f37a3caee820298de22be39ea4b32523 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -278,7 +278,7 @@ class RenderViewSizeObserver : public content::WebContentsObserver {
// Enlarge WebContentsView by |wcv_resize_insets_| while the navigation entry
// is pending.
- virtual void NavigateToPendingEntry(
+ virtual void DidStartNavigationToPendingEntry(
const GURL& url,
NavigationController::ReloadType reload_type) OVERRIDE {
if (wcv_resize_insets_.IsEmpty())
@@ -319,7 +319,8 @@ class RenderViewSizeObserver : public content::WebContentsObserver {
typedef std::map<content::RenderViewHost*, Sizes> RenderViewSizes;
RenderViewSizes render_view_sizes_;
- // Enlarge WebContentsView by this size insets in NavigateToPendingEntry.
+ // Enlarge WebContentsView by this size insets in
+ // DidStartNavigationToPendingEntry.
gfx::Size wcv_resize_insets_;
BrowserWindow* browser_window_; // Weak ptr.
@@ -2544,8 +2545,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, DISABLED_GetSizeForNewRenderView) {
initial_wcv_size.height() + height_inset),
rwhv_create_size2);
// WebContentsView was resized in
- // RenderViewSizeObserver::NavigateToPendingEntry after RenderWidgetHostView
- // was created, so the commit size should be resized accordingly.
+ // RenderViewSizeObserver::DidStartNavigationToPendingEntry after
+ // RenderWidgetHostView was created, so the commit size should be resized
+ // accordingly.
gfx::Size exp_commit_size(initial_wcv_size);
exp_commit_size.Enlarge(wcv_resize_insets.width(),
wcv_resize_insets.height() + height_inset);
« no previous file with comments | « chrome/browser/net/predictor_tab_helper.cc ('k') | chrome/browser/ui/browser_instant_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698