Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 840623002: Do not iterate past the end on processing leaf class. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not iterate past the end on processing leaf class. When checking that the leftmost class of a GC-derived class has the expected shape, take care not step past the end of the leftmost class' own base classes, i.e., when processing A in class A { }; class B : public A, ...some GC base... { }; R=haraken BUG=446580 Committed: https://crrev.com/ab26c4a28236793c15d9daa7cff89173be4cb527 Cr-Commit-Position: refs/heads/master@{#310253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/left_most_gc_base.h View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/left_most_gc_base.txt View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look.
5 years, 11 months ago (2015-01-06 21:07:38 UTC) #2
haraken
LGTM
5 years, 11 months ago (2015-01-07 01:34:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840623002/1
5 years, 11 months ago (2015-01-07 08:12:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 08:54:49 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 08:55:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab26c4a28236793c15d9daa7cff89173be4cb527
Cr-Commit-Position: refs/heads/master@{#310253}

Powered by Google App Engine
This is Rietveld 408576698