tools/clang/blink_gc_plugin/tests/left_most_gc_base.txt - Issue 840623002: Do not iterate past the end on processing leaf class.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/left_most_gc_base.txt

Issue 840623002: Do not iterate past the end on processing leaf class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 In file included from left_most_gc_base.cpp:5:	1 In file included from left_most_gc_base.cpp:5:

2 ./left_most_gc_base.h:15:1: warning: [blink-gc] Class 'Right' must derive its GC base in the left-most position.	2 ./left_most_gc_base.h:15:1: warning: [blink-gc] Class 'Right' must derive its GC base in the left-most position.

3 class Right : public A, public B, public GarbageCollected<Right> { }; // Error	3 class Right : public A, public B, public GarbageCollected<Right> { }; // Error

4 ^	4 ^

5 ./left_most_gc_base.h:18:1: warning: [blink-gc] Class 'DerivedRight' must derive its GC base in the left-most position.	5 ./left_most_gc_base.h:18:1: warning: [blink-gc] Class 'DerivedRight' must derive its GC base in the left-most position.

6 class DerivedRight : public Right, public Left { }; // Error	6 class DerivedRight : public Right, public Left { }; // Error

7 ^	7 ^

8 2 warnings generated.	8 ./left_most_gc_base.h:12:1: warning: [blink-gc] Left-most base class 'A' of deri ved class 'IllFormed' must be polymorphic.

	9 class A { };

	10 ^

	11 ./left_most_gc_base.h:26:1: warning: [blink-gc] Class 'IllFormed' must derive it s GC base in the left-most position.

	12 class IllFormed : public A, public C { }; // Error

	13 ^

	14 4 warnings generated.

OLD	NEW

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/left_most_gc_base.h ('k') | no next file » | no next file with comments »