Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: tools/clang/blink_gc_plugin/tests/left_most_gc_base.txt

Issue 840623002: Do not iterate past the end on processing leaf class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/left_most_gc_base.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/tests/left_most_gc_base.txt
diff --git a/tools/clang/blink_gc_plugin/tests/left_most_gc_base.txt b/tools/clang/blink_gc_plugin/tests/left_most_gc_base.txt
index 4766ea67dec0cda85cf5d359ee64035013426fce..e2d04186773d828a5a180fc250f60d92a983b6a9 100644
--- a/tools/clang/blink_gc_plugin/tests/left_most_gc_base.txt
+++ b/tools/clang/blink_gc_plugin/tests/left_most_gc_base.txt
@@ -5,4 +5,10 @@ class Right : public A, public B, public GarbageCollected<Right> { }; // Error
./left_most_gc_base.h:18:1: warning: [blink-gc] Class 'DerivedRight' must derive its GC base in the left-most position.
class DerivedRight : public Right, public Left { }; // Error
^
-2 warnings generated.
+./left_most_gc_base.h:12:1: warning: [blink-gc] Left-most base class 'A' of derived class 'IllFormed' must be polymorphic.
+class A { };
+^
+./left_most_gc_base.h:26:1: warning: [blink-gc] Class 'IllFormed' must derive its GC base in the left-most position.
+class IllFormed : public A, public C { }; // Error
+^
+4 warnings generated.
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/left_most_gc_base.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698