Chromium Code Reviews
Help | Chromium Project | Sign in
(314)

Issue 8396013: AppCache INTERCEPT namespace. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by michaeln
Modified:
2 years, 4 months ago
Reviewers:
jennb
CC:
chromium-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

AppCache INTERCEPT namespace.
- Add support for a custom CHROMIUM CACHE MANIFEST signature. Other browsers should ignore files with this signature.
- Parse intercept namespace entries out of the new CHROMIUM-INTERCEPT manifest section. Other browsers should ignore this entire section.
- Store and retrieve the new kind of namespace records in the database layer.
- Upgrade existing databases to the new schema.
- Look for matches in the new namespaces when handling main and sub resource requests.
- Add unit tests.

BUG=101565
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114151

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Total comments: 18

Patch Set 10 : '' #

Patch Set 11 : '' #

Total comments: 4

Patch Set 12 : '' #

Total comments: 1

Patch Set 13 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1123 lines, -369 lines) Lint Patch
M sql/connection.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +6 lines, -0 lines 0 comments 0 errors Download
M sql/connection.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +12 lines, -2 lines 0 comments 0 errors Download
M webkit/appcache/appcache.h View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +14 lines, -4 lines 0 comments 0 errors Download
M webkit/appcache/appcache.cc View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +60 lines, -23 lines 0 comments 0 errors Download
M webkit/appcache/appcache_database.h View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +29 lines, -16 lines 0 comments 0 errors Download
M webkit/appcache/appcache_database.cc View 1 2 3 4 5 6 7 8 9 10 11 12 12 chunks +144 lines, -76 lines 0 comments 0 errors Download
M webkit/appcache/appcache_database_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +278 lines, -57 lines 0 comments 4 errors Download
M webkit/appcache/appcache_entry.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -0 lines 0 comments 0 errors Download
M webkit/appcache/appcache_interfaces.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +18 lines, -0 lines 0 comments 0 errors Download
M webkit/appcache/appcache_interfaces.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +18 lines, -5 lines 0 comments 0 errors Download
M webkit/appcache/appcache_storage_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 14 chunks +117 lines, -85 lines 0 comments 0 errors Download
M webkit/appcache/appcache_storage_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 10 chunks +101 lines, -21 lines 1 comment 0 errors Download
M webkit/appcache/appcache_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +46 lines, -11 lines 0 comments 0 errors Download
M webkit/appcache/appcache_update_job.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +9 lines, -5 lines 0 comments 0 errors Download
M webkit/appcache/appcache_update_job_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 10 chunks +76 lines, -14 lines 0 comments 0 errors Download
M webkit/appcache/manifest_parser.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -3 lines 0 comments 0 errors Download
M webkit/appcache/manifest_parser.cc View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +86 lines, -5 lines 0 comments 0 errors Download
M webkit/appcache/manifest_parser_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 chunks +94 lines, -36 lines 0 comments 0 errors Download
M webkit/appcache/mock_appcache_storage_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +8 lines, -6 lines 0 comments 0 errors Download
M webkit/appcache/view_appcache_internals_job.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 10
michaeln
hi jenn, this is quite ready for review yet but its getting close and i'm ...
2 years, 4 months ago #1
jennb
Overall, looks good so far. Looks like most of this is "renaming" of the fallback ...
2 years, 4 months ago #2
michaeln
not updated yet, i'll ping you when i do and add more unit tests... thnx ...
2 years, 4 months ago #3
michaeln
still need new tests http://codereview.chromium.org/8396013/diff/32026/webkit/appcache/appcache_database_unittest.cc File webkit/appcache/appcache_database_unittest.cc (right): http://codereview.chromium.org/8396013/diff/32026/webkit/appcache/appcache_database_unittest.cc#newcode345 webkit/appcache/appcache_database_unittest.cc:345: std::vector<AppCacheDatabase::NamespaceRecord> records; On 2011/12/05 23:23:07, ...
2 years, 4 months ago #4
jennb
Patch set 11 - looks alright so far. I'm trying to look periodically so the ...
2 years, 4 months ago #5
michaeln
I've added unittests in snapshot 12. http://codereview.chromium.org/8396013/diff/42001/sql/connection.h File sql/connection.h (right): http://codereview.chromium.org/8396013/diff/42001/sql/connection.h#newcode289 sql/connection.h:289: // Internal helper ...
2 years, 4 months ago #6
michaeln
http://codereview.chromium.org/8396013/diff/51001/webkit/appcache/appcache_storage_impl.cc File webkit/appcache/appcache_storage_impl.cc (right): http://codereview.chromium.org/8396013/diff/51001/webkit/appcache/appcache_storage_impl.cc#newcode838 webkit/appcache/appcache_storage_impl.cc:838: NetworkNamespaceHelper* network_namespace_helper); hmmm... some compilers might complain about this ...
2 years, 4 months ago #7
michaeln
fixed some lint errors in #13
2 years, 4 months ago #8
michaeln
ping
2 years, 4 months ago #9
jennb
2 years, 4 months ago #10
LGTM

http://codereview.chromium.org/8396013/diff/55002/webkit/appcache/appcache_st...
File webkit/appcache/appcache_storage_impl_unittest.cc (right):

http://codereview.chromium.org/8396013/diff/55002/webkit/appcache/appcache_st...
webkit/appcache/appcache_storage_impl_unittest.cc:978: // MakeCacheAndGroup has
inserted  the default entry record already
extra space in sentence
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6