Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: webkit/appcache/appcache_update_job.cc

Issue 8396013: AppCache INTERCEPT namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/appcache/appcache_update_job.cc
===================================================================
--- webkit/appcache/appcache_update_job.cc (revision 113546)
+++ webkit/appcache/appcache_update_job.cc (working copy)
@@ -869,14 +869,18 @@
AddUrlToFileList(GURL(*it), AppCacheEntry::EXPLICIT);
}
- // TODO(michaeln): Add resources from intercept namepsaces too.
- // http://code.google.com/p/chromium/issues/detail?id=101565
+ const std::vector<Namespace>& intercepts =
+ manifest.intercept_namespaces;
+ for (std::vector<Namespace>::const_iterator it = intercepts.begin();
+ it != intercepts.end(); ++it) {
+ AddUrlToFileList(it->target_url, AppCacheEntry::INTERCEPT);
+ }
- const std::vector<FallbackNamespace>& fallbacks =
+ const std::vector<Namespace>& fallbacks =
manifest.fallback_namespaces;
- for (std::vector<FallbackNamespace>::const_iterator it = fallbacks.begin();
+ for (std::vector<Namespace>::const_iterator it = fallbacks.begin();
it != fallbacks.end(); ++it) {
- AddUrlToFileList(it->second, AppCacheEntry::FALLBACK);
+ AddUrlToFileList(it->target_url, AppCacheEntry::FALLBACK);
}
// Add all master entries from newest complete cache.

Powered by Google App Engine
This is Rietveld 408576698