Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 839413004: Remove the use of page id from building the commit params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl try Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl_unittest.cc
diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc
index e82a5daa73c58c0851e596c68a15c272e2729347..ded5a4be207d4f581cabbe833f670c4554cfbc5c 100644
--- a/content/browser/web_contents/web_contents_impl_unittest.cc
+++ b/content/browser/web_contents/web_contents_impl_unittest.cc
@@ -2909,7 +2909,7 @@ TEST_F(WebContentsImplTest, StartStopEventsBalance) {
// Commit the navigation in the child frame and send the DidStopLoading
// message.
contents()->TestDidNavigate(
- subframe, 3, bar_url, ui::PAGE_TRANSITION_TYPED);
+ subframe, 3, bar_url, ui::PAGE_TRANSITION_MANUAL_SUBFRAME);
Avi (use Gerrit) 2015/02/03 17:39:39 This seemed to work before because the code in the
nasko 2015/02/03 17:45:48 Totally makes sense. More of a copy/paste error on
Charlie Reis 2015/02/03 17:46:56 Great. LGTM.
subframe->OnMessageReceived(
FrameHostMsg_DidStopLoading(subframe->GetRoutingID()));
}
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698