Remove the use of page id from building the commit params.

content/browser/web_contents/web_contents_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/frame_host/cross_site_transferring_request.h"
 #include "content/browser/frame_host/interstitial_page_impl.h"
 #include "content/browser/frame_host/navigation_entry_impl.h"
@@ skipping 2891 matching lines @@
     load_params.frame_tree_node_id =
         subframe->frame_tree_node()->frame_tree_node_id();
     controller().LoadURLWithParams(load_params);
 
     subframe->OnMessageReceived(
         FrameHostMsg_DidStartLoading(subframe->GetRoutingID(), true));
 
     // Commit the navigation in the child frame and send the DidStopLoading
     // message.
     contents()->TestDidNavigate(
-        subframe, 3, bar_url, ui::PAGE_TRANSITION_TYPED);
+        subframe, 3, bar_url, ui::PAGE_TRANSITION_MANUAL_SUBFRAME);

[Avi (use Gerrit), 2015/02/03 17:39:39]

This seemed to work before because the code in the NavigatorImpl was overriding
this value.

AFAIK, subframes can only ever have the transition types manual subframe and
auto subframe. Charlie, is that true? It certainly seems to be enforced by the
code.

[nasko, 2015/02/03 17:45:48]

Totally makes sense. More of a copy/paste error on my side than intentional
value.

[Charlie Reis, 2015/02/03 17:46:56]

Great.  LGTM.

     subframe->OnMessageReceived(
         FrameHostMsg_DidStopLoading(subframe->GetRoutingID()));
   }
 
   // At this point the status should still be loading, since the main frame
   // hasn't sent the DidstopLoading message yet.
   EXPECT_TRUE(contents()->IsLoading());
   EXPECT_TRUE(observer.is_loading());
 
   // Send the DidStopLoading for the main frame and ensure it isn't loading
@@ skipping 100 matching lines @@
 
   // Destroy the remote player. No power save blockers should remain.
   rfh->OnMessageReceived(
       FrameHostMsg_MediaPausedNotification(0, kPlayerRemoteId));
   EXPECT_FALSE(contents()->has_video_power_save_blocker_for_testing());
   EXPECT_FALSE(contents()->has_audio_power_save_blocker_for_testing());
 }
 #endif
 
 }  // namespace content