Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1910)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 839413004: Remove the use of page id from building the commit params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl try Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index ebd10e9739d85a3dbb38636447002fd1893e0df6..d5fbac041d2a045314a3ab623e3d4efb49687bf6 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -504,21 +504,6 @@ void NavigatorImpl::DidNavigate(
bool use_site_per_process = base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kSitePerProcess);
- if (use_site_per_process) {
- // TODO(creis): Until we mirror the frame tree in the subframe's process,
- // cross-process subframe navigations happen in a renderer's main frame.
- // Correct the transition type here if we know it is for a subframe.
- NavigationEntryImpl* pending_entry =
- NavigationEntryImpl::FromNavigationEntry(
- controller_->GetPendingEntry());
- if (!render_frame_host->frame_tree_node()->IsMainFrame() &&
- pending_entry &&
- pending_entry->frame_tree_node_id() ==
- render_frame_host->frame_tree_node()->frame_tree_node_id()) {
- params.transition = ui::PAGE_TRANSITION_AUTO_SUBFRAME;
- }
- }
-
if (ui::PageTransitionIsMainFrame(params.transition)) {
if (delegate_) {
// When overscroll navigation gesture is enabled, a screenshot of the page

Powered by Google App Engine
This is Rietveld 408576698