Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 839293002: Revert of Re-enable the activation behavior of media elements (click to play/pause) (Closed)

Created:
5 years, 11 months ago by jbudorick
Modified:
5 years, 11 months ago
Reviewers:
aberent, philipj_slow, fs
CC:
blink-reviews, nessy, philipj_slow, gasubic, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Re-enable the activation behavior of media elements (click to play/pause) (patchset #3 id:40001 of https://codereview.chromium.org/830183005/) Reason for revert: breaks androidwebview_instrumentation_tests on Android Tests (dbg) on chromium.webkit starting with http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/23717 Original issue's description: > Re-enable the activation behavior of media elements (click to play/pause) > > This revives most of the code and tests from an earlier revert: > https://codereview.chromium.org/249483002 > > The "Don't fire events when interacting with <video controls>" bug has > been fixed, so the native controls and scripted controls will no > longer compete for control: > https://codereview.chromium.org/406213002 > > The definition of "restrained media controller" has been simplified in > spec and implementation since the last time: > https://codereview.chromium.org/262463003 > > BUG=354746 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188141 TBR=fs@opera.com,aberent@chromium.org,philipj@opera.com NOTREECHECKS=true NOTRY=true BUG=354746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -225 lines) Patch
D LayoutTests/media/activation-behavior.html View 1 chunk +0 lines, -111 lines 0 comments Download
D LayoutTests/media/activation-behavior-accesskey.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/media/activation-behavior-fullscreen.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/media/activation-behavior-shadow.html View 1 chunk +0 lines, -45 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jbudorick
Created Revert of Re-enable the activation behavior of media elements (click to play/pause)
5 years, 11 months ago (2015-01-09 17:57:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839293002/1
5 years, 11 months ago (2015-01-09 17:58:01 UTC) #2
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 17:59:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188160

Powered by Google App Engine
This is Rietveld 408576698