Issue 249483002: Disable the activation behavior of media elements (click to play/pause)

Issue 249483002: Disable the activation behavior of media elements (click to play/pause) (Closed)

Created:
6 years, 8 months ago by philipj_slow

Modified:
6 years, 8 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium, ojan

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Disable the activation behavior of media elements (click to play/pause) Sites that implement click to play/pause using JavaScript without calling preventDefault() have unfortunately surfaced. This is serious since at worst the videos are completely unplayable. A remedy would be http://crbug.com/269454 so that no events are fired when the native controls are used. Revert the activation behavior for now, in order to try again after that has been fixed. This partially reverts r169812 and r170789. BUG=354746, 358675 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172484

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -363 lines)			Patch
M	LayoutTests/TestExpectations	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	LayoutTests/media/activation-behavior.html	View	1 chunk	+0 lines, -217 lines	0 comments	Download
D	LayoutTests/media/activation-behavior-accesskey.html	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	LayoutTests/media/activation-behavior-accesskey-expected.txt	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	LayoutTests/media/activation-behavior-expected.txt	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	LayoutTests/media/activation-behavior-fullscreen.html	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	LayoutTests/media/activation-behavior-fullscreen-expected.txt	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	LayoutTests/media/activation-behavior-shadow.html	View	1 chunk	+0 lines, -32 lines	0 comments	Download
D	LayoutTests/media/activation-behavior-shadow-expected.txt	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View	3 chunks	+0 lines, -16 lines	0 comments	Download
M	Source/core/html/shadow/MediaControlElements.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/shadow/MediaControlElements.cpp	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/249483002/1

6 years, 8 months ago (2014-04-24 10:56:05 UTC) #4

Message was sent while issue was closed.

Change committed as 172484

Expand Messages | Collapse Messages