Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 837223007: Add note on ProxyInfo::UseDirect(), etc. to warn that they reset the instance (Closed)

Created:
5 years, 11 months ago by tyoshino (SeeGerritForStatus)
Modified:
5 years, 11 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add note on ProxyInfo::UseDirect(), etc. to warn that they reset the instance R=mmenke BUG=446900 Committed: https://crrev.com/a336c25881ce08f66c0042a9065d4b84d9844619 Cr-Commit-Position: refs/heads/master@{#311412}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed #3 #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M net/proxy/proxy_info.h View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M net/proxy/proxy_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
tyoshino (SeeGerritForStatus)
5 years, 11 months ago (2015-01-09 04:29:51 UTC) #2
mmenke
LGTM https://codereview.chromium.org/837223007/diff/1/net/proxy/proxy_info.h File net/proxy/proxy_info.h (right): https://codereview.chromium.org/837223007/diff/1/net/proxy/proxy_info.h#newcode35 net/proxy/proxy_info.h:35: // call. "ProxyService recognizes" -> "the ProxyService may ...
5 years, 11 months ago (2015-01-09 21:11:15 UTC) #3
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/837223007/diff/1/net/proxy/proxy_info.h File net/proxy/proxy_info.h (right): https://codereview.chromium.org/837223007/diff/1/net/proxy/proxy_info.h#newcode35 net/proxy/proxy_info.h:35: // call. On 2015/01/09 21:11:14, mmenke wrote: > "ProxyService ...
5 years, 11 months ago (2015-01-14 04:20:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837223007/40001
5 years, 11 months ago (2015-01-14 04:22:16 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-14 05:24:19 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 05:25:18 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a336c25881ce08f66c0042a9065d4b84d9844619
Cr-Commit-Position: refs/heads/master@{#311412}

Powered by Google App Engine
This is Rietveld 408576698