net/proxy/proxy_service.cc - Issue 837223007: Add note on ProxyInfo::UseDirect(), etc. to warn that they reset the instance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_service.cc

Issue 837223007: Add note on ProxyInfo::UseDirect(), etc. to warn that they reset the instance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_service.cc

diff --git a/net/proxy/proxy_service.cc b/net/proxy/proxy_service.cc

index f83806ca3f99c77fb3377f66a27601b09edaef99..9d5a0b0b32072abae04e5695e70f9442e0291bc9 100644

--- a/net/proxy/proxy_service.cc

+++ b/net/proxy/proxy_service.cc

@@ -290,7 +290,7 @@ base::Value* NetLogBadProxyListCallback(const ProxyRetryInfoMap* retry_info,

// Returns NetLog parameters on a successfuly proxy resolution.

base::Value* NetLogFinishedResolvingProxyCallback(

- ProxyInfo* result,

+ const ProxyInfo* result,

NetLog::LogLevel /* log_level */) {

base::DictionaryValue* dict = new base::DictionaryValue();

dict->SetString("pac_string", result->ToPacString());

« no previous file with comments | « net/proxy/proxy_info.h ('k') | no next file » | no next file with comments »