Add note on ProxyInfo::UseDirect(), etc. to warn that they reset the instance

net/proxy/proxy_info.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_PROXY_PROXY_INFO_H_
 #define NET_PROXY_PROXY_INFO_H_
 
 #include <string>
 
 #include "base/time/time.h"
@@ skipping 10 matching lines @@
 class NET_EXPORT ProxyInfo {
  public:
   ProxyInfo();
   ~ProxyInfo();
   // Default copy-constructor and assignment operator are OK!
 
   // Uses the same proxy server as the given |proxy_info|.
   void Use(const ProxyInfo& proxy_info);
 
   // Uses a direct connection.
+  //
+  // Note that this method resets this instance unlike Fallback(), etc. which
+  // only modify |proxy_list_|. For example, since |config_id_| is cleared,
+  // ProxyService recognizes this instance as a new config after UseDirect()
+  // call.

[mmenke, 2015/01/09 21:11:14]

"ProxyService recognizes" -> "the ProxyService may recognize"  (Only true if the
old config came from a PAC.  OTherwise, both will have invalid IDs).

[tyoshino (SeeGerritForStatus), 2015/01/14 04:20:36]

Done.

   void UseDirect();
 
   // Uses a direct connection. did_bypass_proxy() will return true to indicate
   // that the direct connection is the result of configured proxy bypass rules.
+  //
+  // See also the note for UseDirect().
   void UseDirectWithBypassedProxy();
 
   // Uses a specific proxy server, of the form:
   //   proxy-uri = [<scheme> "://"] <hostname> [":" <port>]
   // This may optionally be a semi-colon delimited list of <proxy-uri>.
   // It is OK to have LWS between entries.
+  //
+  // See also the note for UseDirect().
   void UseNamedProxy(const std::string& proxy_uri_list);
 
   // Sets the proxy list to a single entry, |proxy_server|.
+  //
+  // See also the note for UseDirect().
   void UseProxyServer(const ProxyServer& proxy_server);
 
   // Parses from the given PAC result.
+  //
+  // See also the note for UseDirect().
   void UsePacString(const std::string& pac_string);
 
   // Use the proxies from the given list.
+  //
+  // See also the note for UseDirect().
   void UseProxyList(const ProxyList& proxy_list);
 
   // Returns true if this proxy info specifies a direct connection.
   bool is_direct() const {
     // We don't implicitly fallback to DIRECT unless it was added to the list.
     if (is_empty())
       return false;
     return proxy_list_.Get().is_direct();
   }
 
@@ skipping 115 matching lines @@
 
   // How long it took to resolve the proxy.  Times are both null if proxy was
   // determined synchronously without running a PAC.
   base::TimeTicks proxy_resolve_start_time_;
   base::TimeTicks proxy_resolve_end_time_;
 };
 
 }  // namespace net
 
 #endif  // NET_PROXY_PROXY_INFO_H_