Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 836923003: Merge TagAppStart and UpdateCurrentAppInfo. (Closed)

Created:
5 years, 11 months ago by derekjchow1
Modified:
5 years, 11 months ago
Reviewers:
lcwu1, byungchul, gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge TagAppStart and UpdateCurrentAppInfo. Removes TagAppStart as its functionality is redundant. Also separates out updating SDK info into UpdateSDKInfo. R=byungchul@chromium.org BUG= Committed: https://crrev.com/3e1f0ec32f25b1a703e8858688a0e280a5e6500e Cr-Commit-Position: refs/heads/master@{#311300}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -26 lines) Patch
M chromecast/base/metrics/cast_metrics_helper.h View 2 chunks +6 lines, -7 lines 0 comments Download
M chromecast/base/metrics/cast_metrics_helper.cc View 1 4 chunks +13 lines, -17 lines 0 comments Download
M chromecast/base/metrics/cast_metrics_test_helper.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
derekjchow1
5 years, 11 months ago (2015-01-12 22:40:14 UTC) #1
byungchul
lgtm https://codereview.chromium.org/836923003/diff/1/chromecast/base/metrics/cast_metrics_helper.cc File chromecast/base/metrics/cast_metrics_helper.cc (right): https://codereview.chromium.org/836923003/diff/1/chromecast/base/metrics/cast_metrics_helper.cc#newcode123 chromecast/base/metrics/cast_metrics_helper.cc:123: TagAppStartForGroupedHistograms(app_id_); Clear sdk_version.
5 years, 11 months ago (2015-01-13 17:30:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836923003/1
5 years, 11 months ago (2015-01-13 17:31:44 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-13 17:31:46 UTC) #7
gunsch
Commit message nits: * it's --> its * remove duplicate first line And please address ...
5 years, 11 months ago (2015-01-13 17:33:27 UTC) #8
derekjchow1
Updated commit message. https://codereview.chromium.org/836923003/diff/1/chromecast/base/metrics/cast_metrics_helper.cc File chromecast/base/metrics/cast_metrics_helper.cc (right): https://codereview.chromium.org/836923003/diff/1/chromecast/base/metrics/cast_metrics_helper.cc#newcode123 chromecast/base/metrics/cast_metrics_helper.cc:123: TagAppStartForGroupedHistograms(app_id_); On 2015/01/13 17:30:01, byungchul wrote: ...
5 years, 11 months ago (2015-01-13 18:11:18 UTC) #9
gunsch
lgtm
5 years, 11 months ago (2015-01-13 18:13:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/836923003/20001
5 years, 11 months ago (2015-01-13 18:18:11 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-13 18:57:04 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 18:58:33 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e1f0ec32f25b1a703e8858688a0e280a5e6500e
Cr-Commit-Position: refs/heads/master@{#311300}

Powered by Google App Engine
This is Rietveld 408576698