Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chromecast/base/metrics/cast_metrics_test_helper.cc

Issue 836923003: Merge TagAppStart and UpdateCurrentAppInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit fixes. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/base/metrics/cast_metrics_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/base/metrics/cast_metrics_test_helper.cc
diff --git a/chromecast/base/metrics/cast_metrics_test_helper.cc b/chromecast/base/metrics/cast_metrics_test_helper.cc
index f3157e268b97e658bf7d5708d514486c7fd88312..c78abe10409bf66563c9b75a2c8c600f99849f8e 100644
--- a/chromecast/base/metrics/cast_metrics_test_helper.cc
+++ b/chromecast/base/metrics/cast_metrics_test_helper.cc
@@ -18,7 +18,9 @@ class CastMetricsHelperStub : public CastMetricsHelper {
CastMetricsHelperStub();
~CastMetricsHelperStub() override;
- void TagAppStart(const std::string& arg_app_name) override;
+ void UpdateCurrentAppInfo(const std::string& app_id,
+ const std::string& session_id) override;
+ void UpdateSDKInfo(const std::string& sdk_version) override;
void LogMediaPlay() override;
void LogMediaPause() override;
void LogTimeToDisplayVideo() override;
@@ -49,7 +51,12 @@ CastMetricsHelperStub::~CastMetricsHelperStub() {
stub_instance_exists = false;
}
-void CastMetricsHelperStub::TagAppStart(const std::string& arg_app_name) {
+void CastMetricsHelperStub::UpdateCurrentAppInfo(
+ const std::string& app_id,
+ const std::string& session_id) {
+}
+
+void CastMetricsHelperStub::UpdateSDKInfo(const std::string& sdk_version) {
}
void CastMetricsHelperStub::LogMediaPlay() {
« no previous file with comments | « chromecast/base/metrics/cast_metrics_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698