Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: chromecast/base/metrics/cast_metrics_helper.h

Issue 836923003: Merge TagAppStart and UpdateCurrentAppInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit fixes. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromecast/base/metrics/cast_metrics_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/base/metrics/cast_metrics_helper.h
diff --git a/chromecast/base/metrics/cast_metrics_helper.h b/chromecast/base/metrics/cast_metrics_helper.h
index 5dbba7c4fa8601ba55f789b87ad4eb298d4fa5e3..144d9dc3b32282c9012c315821c1120f73726e22 100644
--- a/chromecast/base/metrics/cast_metrics_helper.h
+++ b/chromecast/base/metrics/cast_metrics_helper.h
@@ -61,12 +61,12 @@ class CastMetricsHelper {
scoped_refptr<base::MessageLoopProxy> message_loop_proxy);
virtual ~CastMetricsHelper();
- // This function stores the name and startup time of the active application.
- virtual void TagAppStart(const std::string& app_name);
- // This function updates the info for current active application.
+ // This function updates the info and stores the startup time of the current
+ // active application
virtual void UpdateCurrentAppInfo(const std::string& app_id,
- const std::string& session_id,
- const std::string& sdk_version);
+ const std::string& session_id);
+ // This function updates the sdk version of the current active application
+ virtual void UpdateSDKInfo(const std::string& sdk_version);
// Logs UMA record for media play/pause user actions.
virtual void LogMediaPlay();
@@ -139,8 +139,7 @@ class CastMetricsHelper {
// Start time of the most recent app.
base::TimeTicks app_start_time_;
- // Currently running app name. Used to construct histogram name.
- std::string app_name_;
+ // Currently running app id. Used to construct histogram name.
std::string app_id_;
std::string session_id_;
std::string sdk_version_;
« no previous file with comments | « no previous file | chromecast/base/metrics/cast_metrics_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698