Remove client relationship between sky::Inspector{Front,Back}end

Remove client relationship between sky::Inspector{Front,Back}end

This removes the client relationship between the sky::InspectorFrontend
and sky::InspectorBackend mojo interfaces. Instead, the two are now
unrelated (in the mojom) and just happen to be often used together.
The inspector service provides the InspectorFrontend interface to
connecting applications and optimistically tries to connect to the
InspectorBackend interface of applications that connect, in case they
want to receive messages.  The front and back end interfaces are both
broadcast APIs, so no attempt is made to keep track of which binding
is which. If they did need to be correlated this could be easily
accomplished by allocating a new object to keep a
mojo::Binding<sky::InspectorFrontend> and the corresponding
sky::InspectorBackendPtr.

R=abarth@chromium.org, eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/f824c8fadce0427e1793fab63b618f44beb6c574

[jamesr, 2014-12-30 21:56:08]

I think this works but I can't successfully run the inspector to verify.  If I
just run sky/tools/skydb --debug and then hit inspect, here's what I get (with
or without this patch):

$ ./sky/tools/skydb --debug
Loading
https://raw.githubusercontent.com/domokit/mojo/master/sky/examples/home.sky
(skydb) inspect
Open the following URL in Chrome:
chrome-devtools://devtools/bundled/devtools.html?ws=localhost:9898
(skydb) ERROR: Failed to load resource: the server responded with a status of
404 (HTTP/1.1 404 Not Found) 
SOURCE:
https://raw.githubusercontent.com/sky/framework/inspector/inspector.sky:0


and opening that URL in chrome gives me a completely blank inspector UI.

[abarth-chromium, 2014-12-31 06:36:28]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2014-12-31 06:36:29]

lgtm

https://codereview.chromium.org/835463003/diff/1/mojo/common/weak_interface_p...
File mojo/common/weak_interface_ptr_set.h (right):

https://codereview.chromium.org/835463003/diff/1/mojo/common/weak_interface_p...
mojo/common/weak_interface_ptr_set.h:4: 
Don't we need a #define guard?

[jamesr, 2015-01-05 21:57:15]

Thanks, added.  Eric told me how to get the 'inspect' command in skydb working
locally which reveals that this patch breaks it somehow (I don't see anything in
the elements panel).  Since I can 'inspect' on master, I'll try to debug what's
broken with this patch and fix.

[jamesr, 2015-01-06 01:08:11]

jamesr@chromium.org changed reviewers:
+ hansmuller@chromium.org

[jamesr, 2015-01-06 01:08:12]

OK, so the issue here is that while the C++ code is hooking up correctly the
connection from javascript in inspector.sky is not doing the right thing with
this patch.  I've added a comment to inspector.sky explaining what I think I
want to happen and Hans has said he'll take a look at how to do what I want from
JS.

[hansmuller1, 2015-01-06 17:43:11]

On 2015/01/06 01:08:12, jamesr wrote:
> OK, so the issue here is that while the C++ code is hooking up correctly the
> connection from javascript in inspector.sky is not doing the right thing with
> this patch.  I've added a comment to inspector.sky explaining what I think I
> want to happen and Hans has said he'll take a look at how to do what I want
from
> JS.

I've added a JS example that demos demos sharing services between application
ServiceProviders. It's https://codereview.chromium.org/839553004.

Currently Sky doesn't use the JS Application, Shell, and ServiceProvider classes
however I think it could. Looking into that now.

[hansmuller1, 2015-01-08 17:58:55]

On 2015/01/06 17:43:11, hansmuller1 wrote:
> On 2015/01/06 01:08:12, jamesr wrote:
> > OK, so the issue here is that while the C++ code is hooking up correctly the
> > connection from javascript in inspector.sky is not doing the right thing
with
> > this patch.  I've added a comment to inspector.sky explaining what I think I
> > want to happen and Hans has said he'll take a look at how to do what I want
> from
> > JS.
> 
> I've added a JS example that demos demos sharing services between application
> ServiceProviders. It's https://codereview.chromium.org/839553004.
> 
> Currently Sky doesn't use the JS Application, Shell, and ServiceProvider
classes
> however I think it could. Looking into that now.

I've done this: https://codereview.chromium.org/837283002/. The
sky/tests/services/network.sky test demos creating a JS Application and etc.

[jamesr, 2015-01-08 21:46:23]

OK, this one seems to actually work!

Hans - could you review the inspector.sky changes?

[hansmuller1, 2015-01-08 21:53:37]

On 2015/01/08 21:46:23, jamesr wrote:
> OK, this one seems to actually work!
> 
> Hans - could you review the inspector.sky changes?

The inspector.sky changes LGTM.

[jamesr, 2015-01-09 22:50:44]

Committed patchset #3 (id:40001) manually as
f824c8fadce0427e1793fab63b618f44beb6c574 (presubmit successful).