Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 839553004: Mojo JS Bindings: Update User's Guide, examples (Closed)

Created:
5 years, 11 months ago by hansmuller
Modified:
5 years, 11 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojo JS Bindings: Update User's Guide, examples - Added echo_share example, demos sharing services between application ServiceProviders. - Follow the convention about creating variables for module classes in the examples. - Revised the User's Guide. BUG= R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/acc0be86c70bb7cf47e02635f6326a2142201cec

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -136 lines) Patch
M examples/js/README.md View 1 chunk +6 lines, -4 lines 0 comments Download
M examples/js/cube.js View 7 chunks +26 lines, -21 lines 1 comment Download
M examples/js/hello.js View 1 chunk +4 lines, -2 lines 0 comments Download
A examples/js/share_echo.js View 1 chunk +45 lines, -0 lines 0 comments Download
A examples/js/share_echo_target.js View 1 chunk +36 lines, -0 lines 0 comments Download
M examples/js/users-guide.md View 8 chunks +203 lines, -102 lines 0 comments Download
M examples/js/wget.js View 3 chunks +9 lines, -5 lines 0 comments Download
M examples/js/world.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
eseidel
lgtm https://codereview.chromium.org/839553004/diff/1/examples/js/cube.js File examples/js/cube.js (right): https://codereview.chromium.org/839553004/diff/1/examples/js/cube.js#newcode29 examples/js/cube.js:29: var Application = application.Application; Can we use const?
5 years, 11 months ago (2015-01-06 21:02:01 UTC) #2
hansmuller1
On 2015/01/06 21:02:01, eseidel wrote: > lgtm > > https://codereview.chromium.org/839553004/diff/1/examples/js/cube.js > File examples/js/cube.js (right): > ...
5 years, 11 months ago (2015-01-06 21:08:29 UTC) #3
hansmuller1
On 2015/01/06 21:08:29, hansmuller1 wrote: > On 2015/01/06 21:02:01, eseidel wrote: > > lgtm > ...
5 years, 11 months ago (2015-01-06 21:10:05 UTC) #4
hansmuller
5 years, 11 months ago (2015-01-06 21:11:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
acc0be86c70bb7cf47e02635f6326a2142201cec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698