Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: sky/framework/inspector/inspector.sky

Issue 835463003: Remove client relationship between sky::Inspector{Front,Back}end (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: provide InspectorBackend impl from inspector.sky Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/v8_inspector/inspector_backend_mojo.cc ('k') | sky/services/inspector/inspector.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/inspector/inspector.sky
diff --git a/sky/framework/inspector/inspector.sky b/sky/framework/inspector/inspector.sky
index 62c53fb3bf2fca72a4d6cb2f24ea0e80709ead83..4d5107de19a95c7e7b8d782f7b8cd114191c51b4 100644
--- a/sky/framework/inspector/inspector.sky
+++ b/sky/framework/inspector/inspector.sky
@@ -1,6 +1,7 @@
<import src="/mojo/public/sky/connection.sky" as="connection" />
<import src="/mojo/public/sky/core.sky" as="core" />
<import src="/mojo/public/sky/support.sky" as="support" />
+<import src="/mojo/services/public/sky/application.sky" as="application" />
<import src="/sky/services/inspector/inspector.mojom.sky" as="inspector" />
<import src="console-agent.sky" as="ConsoleAgent" />
<import src="dom-agent.sky" as="DOMAgent" />
@@ -11,7 +12,6 @@
<import src="css-agent.sky" as="CSSAgent" />
<script>
function InspectorBackend(frontend) {
- this.frontend = frontend;
var domAgent = new DOMAgent(this);
this.agents = {
Console: new ConsoleAgent(),
@@ -104,7 +104,7 @@ InspectorBackend.prototype.sendResponse = function(message_id, result) {
};
if (typeof result !== "undefined")
response.result = result;
- this.frontend.sendMessage(JSON.stringify(response));
+ window.frontend.sendMessage(JSON.stringify(response));
}
InspectorBackend.prototype.sendMessage = function(method, params) {
@@ -112,15 +112,16 @@ InspectorBackend.prototype.sendMessage = function(method, params) {
method: method,
params: params,
});
- this.frontend.sendMessage(message);
+ window.frontend.sendMessage(message);
};
-var frontendHandle = internals.connectToService(
- "mojo:sky_inspector_server", inspector.InspectorFrontend.name);
-window.frontendConnection = new connection.Connection(
- frontendHandle,
- InspectorBackend,
- inspector.InspectorFrontend.proxyClass);
+(function() {
+ var app = new application.Application(internals.passShellProxyHandle());
+ var tracingApp = app.shell.connectToApplication("mojo:sky_inspector_server");
+ tracingApp.provideService(inspector.InspectorBackend, InspectorBackend);
+
+ window.frontend = tracingApp.requestService(inspector.InspectorFrontend);
+})();
+
-window.frontend = frontendConnection.remote;
</script>
« no previous file with comments | « sky/engine/v8_inspector/inspector_backend_mojo.cc ('k') | sky/services/inspector/inspector.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698