Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 835353004: Prevent expandos on all SkyElements. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Prevent expandos on all SkyElements. Expandos make v8 sad, lets not allow them. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1515fd38dee90ef09520c47f639c268da46868f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M sky/examples/city-list/city-list.sky View 7 chunks +13 lines, -3 lines 0 comments Download
M sky/framework/sky-element/sky-element.sky View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
5 years, 11 months ago (2015-01-08 23:27:13 UTC) #2
ojan
lgtm
5 years, 11 months ago (2015-01-08 23:28:32 UTC) #3
esprehn
5 years, 11 months ago (2015-01-08 23:30:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1515fd38dee90ef09520c47f639c268da46868f4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698