sky/framework/sky-element/sky-element.sky - Issue 835353004: Prevent expandos on all SkyElements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/framework/sky-element/sky-element.sky

Issue 835353004: Prevent expandos on all SkyElements. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/framework/sky-element/sky-element.sky

diff --git a/sky/framework/sky-element/sky-element.sky b/sky/framework/sky-element/sky-element.sky

index 30f5302d99af1da71f1f3fc7d57975db0098c29b..adb7e28640924e0b0b8185a41602c31cc7d2f0cc 100644

--- a/sky/framework/sky-element/sky-element.sky

+++ b/sky/framework/sky-element/sky-element.sky

@@ -101,6 +101,8 @@ class SkyElement extends HTMLElement {

this.isAttached = false;

this.created();

+ Object.preventExtensions(this);

// Invoke attributeChanged callback when element is first created too.

var attributes = this.getAttributes();

for (var i = 0; i < attributes.length; ++i) {

« no previous file with comments | « sky/examples/city-list/city-list.sky ('k') | no next file » | no next file with comments »