Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: sky/examples/city-list/city-list.sky

Issue 835353004: Prevent expandos on all SkyElements. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/framework/sky-element/sky-element.sky » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/city-list/city-list.sky
diff --git a/sky/examples/city-list/city-list.sky b/sky/examples/city-list/city-list.sky
index 4306c93455819054379c850cc057d4a08ac8af78..1d75dc26960019e002d3254eae22e6cb23c1a6fc 100644
--- a/sky/examples/city-list/city-list.sky
+++ b/sky/examples/city-list/city-list.sky
@@ -27,6 +27,9 @@ module.exports = {};
</template>
<script>
module.exports.StateHeaderElement = class extends SkyElement {
+ created() {
+ this.state = "";
+ }
set datum(datum) {
this.state = datum.state;
}
@@ -49,6 +52,9 @@ module.exports.StateHeaderElement = class extends SkyElement {
</template>
<script>
module.exports.LetterHeaderElement = class extends SkyElement {
+ created() {
+ this.letter = "";
+ }
set datum(datum) {
this.letter = datum.letter;
}
@@ -92,6 +98,10 @@ module.exports.LetterHeaderElement = class extends SkyElement {
</template>
<script>
module.exports.CityItemElement = class extends SkyElement {
+ created() {
+ this.name = "";
+ this.population = "";
+ }
set datum(datum) {
this.name = datum.name;
this.population = datum.population;
@@ -553,6 +563,7 @@ module.exports.CityItemElement = class extends SkyElement {
this.date = null;
this.month = null;
this.views = null;
+ this.scrollerElement = null;
}
attached() {
@@ -566,7 +577,6 @@ module.exports.CityItemElement = class extends SkyElement {
cityItem: 30
});
- this.dataLoaded = this.dataLoaded.bind(this);
this.scrollerElement = this.shadowRoot.getElementById('scroller');
this.scrollerElement.addEventListener('scroll',
this.handleScroll.bind(this));
@@ -574,7 +584,7 @@ module.exports.CityItemElement = class extends SkyElement {
var self = this;
setTimeout(function() {
self.domReady();
- self.loader.maybeLoadMoreData(self.dataLoaded);
+ self.loader.maybeLoadMoreData(self.dataLoaded.bind(self));
});
}
@@ -591,7 +601,7 @@ module.exports.CityItemElement = class extends SkyElement {
this.tiler.drawTiles(scrollFrame, data);
var datum = scrollChanged ?
this.tiler.getFirstVisibleDatum(scrollFrame) : null;
- this.loader.maybeLoadMoreData(this.dataLoaded, datum);
+ this.loader.maybeLoadMoreData(this.dataLoaded.bind(this), datum);
}
dataLoaded(data, indexOffset) {
« no previous file with comments | « no previous file | sky/framework/sky-element/sky-element.sky » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698