Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 834693007: Remove the remaining parts of ignorePendingStylesheets and placeholder styles. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan, abarth-chromium
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove the remaining parts of ignorePendingStylesheets and placeholder styles. This patch is largely just a rename since updateLayoutIgnorePendingStylesheets() didn't really do anything except call updateLayout() now as nothing was reading the ignorePendingStyleSheets state, and no callers used the synchronous post layout task option which was meant for plugins (which Sky doesn't have). Placeholder styles were related and just add confusion since things pretend to be display: none while <import>'s are loading. We should expose a real API for avoiding FOUC instead of pumping frames with display: none elements when imports are loading. I had to skip the layout/continuations.sky test since it always crashes now with an ASSERT failure about a bad cast (filed as bug 446739). The bug already existed, this patch just makes that one test hit it. BUG=446739 R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c455e81dbc3404a82f0767a62f507f276d1650fd

Patch Set 1 #

Patch Set 2 : Skip crashing test #

Total comments: 1

Patch Set 3 : Remove comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -150 lines) Patch
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
M sky/engine/core/dom/Document.h View 3 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 3 chunks +0 lines, -23 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 20 chunks +23 lines, -21 lines 0 comments Download
M sky/engine/core/dom/Range.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/RenderTreeBuilder.h View 1 chunk +1 line, -6 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.h View 3 chunks +0 lines, -14 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/editing/ApplyBlockElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/editing/CompositeEditCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/editing/DeleteSelectionCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/editing/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/editing/FrameSelection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/editing/InsertLineBreakCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/editing/InsertParagraphSeparatorCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/editing/ReplaceSelectionCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/editing/TextIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/editing/VisiblePosition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/editing/VisibleUnits.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/editing/htmlediting.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/events/MouseRelatedEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/HTMLImageElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/html/HTMLImageElement.cpp View 5 chunks +6 lines, -12 lines 0 comments Download
M sky/engine/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/page/FocusController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/web/WebNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/tests/TestExpectations View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
5 years, 11 months ago (2015-01-07 05:53:53 UTC) #2
ojan
lgtm https://codereview.chromium.org/834693007/diff/20001/sky/tests/TestExpectations File sky/tests/TestExpectations (right): https://codereview.chromium.org/834693007/diff/20001/sky/tests/TestExpectations#newcode26 sky/tests/TestExpectations:26: # These tests crash Nit: Don't need this ...
5 years, 11 months ago (2015-01-07 18:50:44 UTC) #3
esprehn
5 years, 11 months ago (2015-01-07 18:54:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c455e81dbc3404a82f0767a62f507f276d1650fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698