Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: sky/engine/core/dom/RenderTreeBuilder.h

Issue 834693007: Remove the remaining parts of ignorePendingStylesheets and placeholder styles. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Remove comment. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/dom/Range.cpp ('k') | sky/engine/core/dom/StyleEngine.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
7 * Copyright (C) 2011 Google Inc. All rights reserved. 7 * Copyright (C) 2011 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 30 matching lines...) Expand all
41 STACK_ALLOCATED(); 41 STACK_ALLOCATED();
42 public: 42 public:
43 RenderTreeBuilder(Node* node, RenderStyle* style) 43 RenderTreeBuilder(Node* node, RenderStyle* style)
44 : m_node(node) 44 : m_node(node)
45 , m_renderingParent(nullptr) 45 , m_renderingParent(nullptr)
46 , m_style(style) 46 , m_style(style)
47 { 47 {
48 ASSERT(!node->renderer()); 48 ASSERT(!node->renderer());
49 ASSERT(node->needsAttach()); 49 ASSERT(node->needsAttach());
50 ASSERT(node->document().inStyleRecalc()); 50 ASSERT(node->document().inStyleRecalc());
51 51 ASSERT(node->inActiveDocument());
52 // FIXME: We should be able to ASSERT(node->inActiveDocument()) but chil drenChanged is called
53 // before ChildNodeInsertionNotifier in ContainerNode's methods and some implementations
54 // will trigger a layout inside childrenChanged.
55 // Mainly HTMLTextAreaElement::childrenChanged calls HTMLTextFormControl Element::setSelectionRange
56 // which does an updateLayoutIgnorePendingStylesheets.
57 52
58 m_renderingParent = NodeRenderingTraversal::parent(node, &m_parentDetail s); 53 m_renderingParent = NodeRenderingTraversal::parent(node, &m_parentDetail s);
59 } 54 }
60 55
61 void createRendererForTextIfNeeded(); 56 void createRendererForTextIfNeeded();
62 void createRendererForElementIfNeeded(); 57 void createRendererForElementIfNeeded();
63 58
64 private: 59 private:
65 RenderObject* parentRenderer() const; 60 RenderObject* parentRenderer() const;
66 RenderObject* nextRenderer() const; 61 RenderObject* nextRenderer() const;
67 bool shouldCreateRenderer() const; 62 bool shouldCreateRenderer() const;
68 RenderStyle& style() const; 63 RenderStyle& style() const;
69 64
70 RawPtr<Node> m_node; 65 RawPtr<Node> m_node;
71 RawPtr<ContainerNode> m_renderingParent; 66 RawPtr<ContainerNode> m_renderingParent;
72 NodeRenderingTraversal::ParentDetails m_parentDetails; 67 NodeRenderingTraversal::ParentDetails m_parentDetails;
73 mutable RefPtr<RenderStyle> m_style; 68 mutable RefPtr<RenderStyle> m_style;
74 }; 69 };
75 70
76 } // namespace blink 71 } // namespace blink
77 72
78 #endif // SKY_ENGINE_CORE_DOM_RENDERTREEBUILDER_H_ 73 #endif // SKY_ENGINE_CORE_DOM_RENDERTREEBUILDER_H_
OLDNEW
« no previous file with comments | « sky/engine/core/dom/Range.cpp ('k') | sky/engine/core/dom/StyleEngine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698