Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 834383004: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/login/ui. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, davemoore+watch_chromium.org, dzhioev+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/login/ui. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=sky@chromium.org Committed: https://crrev.com/77fc7b7776899bbaee5bcb2a108c16d8796a60a6 Cr-Commit-Position: refs/heads/master@{#311792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -258 lines) Patch
M chrome/browser/chromeos/login/ui/captive_portal_view.h View 1 chunk +10 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc View 4 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/ui/captive_portal_window_proxy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/ui/input_events_blocker.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/ui/keyboard_driven_oobe_key_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/lock_window_aura.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.h View 3 chunks +32 lines, -36 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 2 chunks +8 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_web_dialog.h View 2 chunks +18 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/login/ui/models/user_board_model.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/ui/proxy_settings_dialog.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/simple_web_view_dialog.h View 2 chunks +24 lines, -29 lines 0 comments Download
M chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/ui/simple_web_view_dialog_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/ui/user_adding_screen.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/ui/user_adding_screen_input_methods_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.h View 1 chunk +45 lines, -46 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.h View 3 chunks +32 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
5 years, 11 months ago (2015-01-15 21:11:05 UTC) #1
sky
LGTM
5 years, 11 months ago (2015-01-15 23:51:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834383004/1
5 years, 11 months ago (2015-01-15 23:53:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 00:49:14 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:51:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77fc7b7776899bbaee5bcb2a108c16d8796a60a6
Cr-Commit-Position: refs/heads/master@{#311792}

Powered by Google App Engine
This is Rietveld 408576698