chrome/browser/chromeos/login/ui/proxy_settings_dialog.h - Issue 834383004: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/login/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/ui/proxy_settings_dialog.h

Issue 834383004: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/login/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/ui/models/user_board_model.h ('k') | chrome/browser/chromeos/login/ui/simple_web_view_dialog.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/ui/proxy_settings_dialog.h

diff --git a/chrome/browser/chromeos/login/ui/proxy_settings_dialog.h b/chrome/browser/chromeos/login/ui/proxy_settings_dialog.h

index b6b5df66becf9e26297f8883d4abdc0bd2f3a011..bc5d7153019256380ea3063d27bcdbb4e09cbea5 100644

--- a/chrome/browser/chromeos/login/ui/proxy_settings_dialog.h

+++ b/chrome/browser/chromeos/login/ui/proxy_settings_dialog.h

@@ -26,11 +26,11 @@ class ProxySettingsDialog : public LoginWebDialog {

const NetworkState& network,

LoginWebDialog::Delegate* delegate,

gfx::NativeWindow window);

- virtual ~ProxySettingsDialog();

+ ~ProxySettingsDialog() override;

protected:

// ui::WebDialogDelegate implementation.

- virtual void OnDialogClosed(const std::string& json_retval) override;

+ void OnDialogClosed(const std::string& json_retval) override;

private:

// TODO(altimofeev): consider avoidance static variable by extending current