chrome/browser/chromeos/login/ui/captive_portal_window_proxy.h - Issue 834383004: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/login/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/ui/captive_portal_window_proxy.h

Issue 834383004: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/login/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc ('k') | chrome/browser/chromeos/login/ui/input_events_blocker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/ui/captive_portal_window_proxy.h

diff --git a/chrome/browser/chromeos/login/ui/captive_portal_window_proxy.h b/chrome/browser/chromeos/login/ui/captive_portal_window_proxy.h

index 2ed00e24c6079eb30cf0b14dc84e515fa9eff1a7..53482b24027816fc032049d1ca6c4ca506cb6be6 100644

--- a/chrome/browser/chromeos/login/ui/captive_portal_window_proxy.h

+++ b/chrome/browser/chromeos/login/ui/captive_portal_window_proxy.h

@@ -38,7 +38,7 @@ class CaptivePortalWindowProxy : public views::WidgetObserver {

CaptivePortalWindowProxy(Delegate* delegate,

content::WebContents* web_contents);

- virtual ~CaptivePortalWindowProxy();

+ ~CaptivePortalWindowProxy() override;

// Shows captive portal window only after a redirection has happened. So it is

// safe to call this method, when the caller isn't 100% sure that the network

@@ -62,9 +62,9 @@ class CaptivePortalWindowProxy : public views::WidgetObserver {

void OnOriginalURLLoaded();

// Overridden from views::WidgetObserver:

- virtual void OnWidgetClosing(views::Widget* widget) override;

- virtual void OnWidgetDestroying(views::Widget* widget) override;

- virtual void OnWidgetDestroyed(views::Widget* widget) override;

+ void OnWidgetClosing(views::Widget* widget) override;

+ void OnWidgetDestroying(views::Widget* widget) override;

+ void OnWidgetDestroyed(views::Widget* widget) override;

private:

friend class CaptivePortalWindowTest;