tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt - Issue 834373003: BlinkGCPlugin: require GC mixin instances to declare local trace().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt

Issue 834373003: BlinkGCPlugin: require GC mixin instances to declare local trace(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing 'override' annotations; sync heap/stubs.h with upstream defs Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_requires_trace_method.cpp ('k') | tools/clang/blink_gc_plugin/tests/garbage_collected_mixin.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt

diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt b/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt

index de6fd949adda1b2c73e5762bac61a2800f7caea0..15231c106d7c509260fefcbcf3de9cbe23d5cdc2 100644

--- a/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt

+++ b/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt

@@ -11,4 +11,10 @@ class HeapObject : public GarbageCollected<HeapObject> {

./class_requires_trace_method.h:22:5: note: [blink-gc] Untraced field 'm_part' declared here:

PartObject m_part;

-2 warnings generated.

+./class_requires_trace_method.h:31:1: warning: [blink-gc] Class 'HeapObjectMixin' which inherits from GarbageCollectedMixin must locally declare and override trace(Visitor*)

+class HeapObjectMixin : public GarbageCollected<HeapObjectMixin>, public Mixin {

+./class_requires_trace_method.h:40:1: warning: [blink-gc] Class 'HeapObjectMixin2' which inherits from GarbageCollectedMixin must locally declare and override trace(Visitor*)

+class HeapObjectMixin2

+4 warnings generated.