tools/clang/blink_gc_plugin/tests/class_requires_trace_method.cpp - Issue 834373003: BlinkGCPlugin: require GC mixin instances to declare local trace().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_trace_method.cpp

Issue 834373003: BlinkGCPlugin: require GC mixin instances to declare local trace(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing 'override' annotations; sync heap/stubs.h with upstream defs Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_requires_trace_method.h ('k') | tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/class_requires_trace_method.cpp

diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.cpp b/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.cpp

index 866b35120905710458bd0d4c6482f9fa2c73ccbb..f18fdf6d3265c0c7c1aa573740b2001c2513a71f 100644

--- a/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.cpp

+++ b/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.cpp

@@ -4,4 +4,16 @@

#include "class_requires_trace_method.h"

-// Nothing to define.

+namespace blink {

+void Mixin2::trace(Visitor* visitor)

+ Mixin::trace(visitor);

+void Mixin3::trace(Visitor* visitor)

+ Mixin::trace(visitor);

+} // namespace blink