tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt - Issue 834373003: BlinkGCPlugin: require GC mixin instances to declare local trace().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt

Issue 834373003: BlinkGCPlugin: require GC mixin instances to declare local trace(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing 'override' annotations; sync heap/stubs.h with upstream defs Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_requires_trace_method.cpp ('k') | tools/clang/blink_gc_plugin/tests/garbage_collected_mixin.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 In file included from class_requires_trace_method.cpp:5:	1 In file included from class_requires_trace_method.cpp:5:

2 ./class_requires_trace_method.h:14:1: warning: [blink-gc] Class 'PartObject' req uires a trace method.	2 ./class_requires_trace_method.h:14:1: warning: [blink-gc] Class 'PartObject' req uires a trace method.

3 class PartObject {	3 class PartObject {

4 ^	4 ^

5 ./class_requires_trace_method.h:17:5: note: [blink-gc] Untraced field 'm_obj' de clared here:	5 ./class_requires_trace_method.h:17:5: note: [blink-gc] Untraced field 'm_obj' de clared here:

6 Member<HeapObject> m_obj;	6 Member<HeapObject> m_obj;

7 ^	7 ^

8 ./class_requires_trace_method.h:20:1: warning: [blink-gc] Class 'HeapObject' req uires a trace method.	8 ./class_requires_trace_method.h:20:1: warning: [blink-gc] Class 'HeapObject' req uires a trace method.

9 class HeapObject : public GarbageCollected<HeapObject> {	9 class HeapObject : public GarbageCollected<HeapObject> {

10 ^	10 ^

11 ./class_requires_trace_method.h:22:5: note: [blink-gc] Untraced field 'm_part' d eclared here:	11 ./class_requires_trace_method.h:22:5: note: [blink-gc] Untraced field 'm_part' d eclared here:

12 PartObject m_part;	12 PartObject m_part;

13 ^	13 ^

14 2 warnings generated.	14 ./class_requires_trace_method.h:31:1: warning: [blink-gc] Class 'HeapObjectMixin ' which inherits from GarbageCollectedMixin must locally declare and override tr ace(Visitor*)

	15 class HeapObjectMixin : public GarbageCollected<HeapObjectMixin>, public Mixin {

	16 ^

	17 ./class_requires_trace_method.h:40:1: warning: [blink-gc] Class 'HeapObjectMixin 2' which inherits from GarbageCollectedMixin must locally declare and override t race(Visitor*)

	18 class HeapObjectMixin2

	19 ^

	20 4 warnings generated.

OLD	NEW