Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_trace_method.h

Issue 834373003: BlinkGCPlugin: require GC mixin instances to declare local trace(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing 'override' annotations; sync heap/stubs.h with upstream defs Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/class_requires_trace_method.h
diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.h b/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.h
index 82cad15e884d799d066537ecb293ab5b61eb2a65..782d80e141dafc43feff82718ed442b9a97ada26 100644
--- a/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.h
+++ b/tools/clang/blink_gc_plugin/tests/class_requires_trace_method.h
@@ -22,6 +22,38 @@ private:
PartObject m_part;
};
+class Mixin : public GarbageCollectedMixin {
+public:
+ virtual void trace(Visitor*) override;
+ Member<Mixin> m_self;
+};
+
+class HeapObjectMixin : public GarbageCollected<HeapObjectMixin>, public Mixin {
+ USING_GARBAGE_COLLECTED_MIXIN(HeapObjectMixin);
+};
+
+class Mixin2 : public Mixin {
+public:
+ virtual void trace(Visitor*) override;
+};
+
+class HeapObjectMixin2
+ : public GarbageCollected<HeapObjectMixin2>, public Mixin2 {
+ USING_GARBAGE_COLLECTED_MIXIN(HeapObjectMixin2);
+};
+
+class Mixin3 : public Mixin {
+public:
+ virtual void trace(Visitor*) override;
+};
+
+class HeapObjectMixin3
+ : public GarbageCollected<HeapObjectMixin3>, public Mixin {
+ USING_GARBAGE_COLLECTED_MIXIN(HeapObjectMixin2);
+public:
+ virtual void trace(Visitor*) override;
+};
+
}
#endif

Powered by Google App Engine
This is Rietveld 408576698