tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h - Issue 834373003: BlinkGCPlugin: require GC mixin instances to declare local trace().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h

Issue 834373003: BlinkGCPlugin: require GC mixin instances to declare local trace(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing 'override' annotations; sync heap/stubs.h with upstream defs Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt ('k') | tools/clang/blink_gc_plugin/tests/class_requires_trace_method.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h

diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h

index d56a57ea6c543ae4d15f57c135c1cc0e1e8d0f93..929785d7ad04fe23a62afcf67f5d3bd145e950a5 100644

--- a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h

+++ b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h

@@ -14,7 +14,7 @@ class OnHeap : public GarbageCollected<OnHeap> { };

class MixinFinalizable : public GarbageCollectedMixin {

public:

- void trace(Visitor*);

+ virtual void trace(Visitor*) override;

private:

RefPtr<OffHeap> m_offHeap; // Requires finalization

Member<OnHeap> m_onHeap;

@@ -22,7 +22,7 @@ private:

class MixinNotFinalizable : public GarbageCollectedMixin {

public:

- void trace(Visitor*);

+ virtual void trace(Visitor*) override;

private:

Member<OnHeap> m_onHeap;

};

@@ -32,7 +32,7 @@ class NeedsFinalizer

, public MixinFinalizable {

USING_GARBAGE_COLLECTED_MIXIN(NeedsFinalizer);

public:

- void trace(Visitor*);

+ virtual void trace(Visitor*) override;

private:

Member<OnHeap> m_obj;

};

@@ -41,7 +41,7 @@ class HasFinalizer : public GarbageCollectedFinalized<HasFinalizer>,

public MixinFinalizable {

USING_GARBAGE_COLLECTED_MIXIN(HasFinalizer);

public:

- void trace(Visitor*);

+ virtual void trace(Visitor*) override;

private:

Member<OnHeap> m_obj;

};

@@ -52,7 +52,7 @@ class NeedsNoFinalization

, public ScriptWrappable {

USING_GARBAGE_COLLECTED_MIXIN(NeedsNoFinalization);

public:

- void trace(Visitor*);

+ virtual void trace(Visitor*) override;

private:

Member<OnHeap> m_obj;

};