tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt - Issue 834373003: BlinkGCPlugin: require GC mixin instances to declare local trace().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt

Issue 834373003: BlinkGCPlugin: require GC mixin instances to declare local trace(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing 'override' annotations; sync heap/stubs.h with upstream defs Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/RecordInfo.cpp ('k') | tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt

diff --git a/tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt b/tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt

index 2e697fea851aad31b365e3c79a4d2725eee5d1e9..a8f270bfb6fba143285163d59a851616b7915db8 100644

--- a/tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt

+++ b/tools/clang/blink_gc_plugin/tests/class_multiple_trace_bases.txt

@@ -8,4 +8,7 @@ class Derived : public Base, public Mixin {

./class_multiple_trace_bases.h:22:30: note: [blink-gc] Untraced base class 'Mixin' declared here:

class Derived : public Base, public Mixin {

-1 warning generated.

+./class_multiple_trace_bases.h:22:1: warning: [blink-gc] Class 'Derived' which inherits from GarbageCollectedMixin must locally declare and override trace(Visitor*)

+class Derived : public Base, public Mixin {

+2 warnings generated.