Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 834353003: Adding user doc section and core files for new site (Closed)

Created:
5 years, 11 months ago by hcm
Modified:
5 years, 11 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org, tfarina
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Adding user doc section and core files for new site - Updated QSGs with relative links to download page, removed outdated and googler-only iOS instructions. - Will add "contributing" page and update project roles link in next batch with developer section Preview link: http://skiadocs.com:8000/user/quick/android?cl=834353003 BUG=skia: Committed: https://skia.googlesource.com/skia/+/343c2f4dfbabb9cadacd524e07006b1adc9446c2

Patch Set 1 #

Total comments: 4

Patch Set 2 : Formatting fixes #

Patch Set 3 : One more fix to android.md #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1066 lines, -0 lines) Patch
A site/user/quick/android.md View 1 2 1 chunk +167 lines, -0 lines 0 comments Download
A site/user/quick/index.md View 1 chunk +3 lines, -0 lines 0 comments Download
A site/user/quick/ios.md View 1 chunk +104 lines, -0 lines 0 comments Download
A site/user/quick/macos.md View 1 chunk +69 lines, -0 lines 0 comments Download
A site/user/quick/nacl.md View 1 chunk +93 lines, -0 lines 0 comments Download
A site/user/quick/windows.md View 1 chunk +96 lines, -0 lines 0 comments Download
A site/user/sample/building.md View 1 1 chunk +320 lines, -0 lines 0 comments Download
A site/user/sample/hello.md View 1 chunk +123 lines, -0 lines 0 comments Download
A site/user/sample/index.md View 1 chunk +2 lines, -0 lines 0 comments Download
A site/user/special/index.md View 1 chunk +3 lines, -0 lines 0 comments Download
A site/user/special/lua.md View 1 1 chunk +54 lines, -0 lines 0 comments Download
A site/user/special/windows_angle.md View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
hcm
5 years, 11 months ago (2015-01-06 20:58:35 UTC) #2
jcgregorio
https://codereview.chromium.org/834353003/diff/1/site/user/quick/android.md File site/user/quick/android.md (right): https://codereview.chromium.org/834353003/diff/1/site/user/quick/android.md#newcode14 site/user/quick/android.md:14: $ sudo apt-get install ant git ~~~~ $ sudo ...
5 years, 11 months ago (2015-01-07 13:53:23 UTC) #3
hcm
On 2015/01/07 13:53:23, jcgregorio wrote: > https://codereview.chromium.org/834353003/diff/1/site/user/quick/android.md > File site/user/quick/android.md (right): > > https://codereview.chromium.org/834353003/diff/1/site/user/quick/android.md#newcode14 > ...
5 years, 11 months ago (2015-01-08 17:01:58 UTC) #4
jcgregorio
lgtm
5 years, 11 months ago (2015-01-08 18:18:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834353003/40001
5 years, 11 months ago (2015-01-08 18:35:20 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/343c2f4dfbabb9cadacd524e07006b1adc9446c2
5 years, 11 months ago (2015-01-08 18:43:37 UTC) #8
tfarina
Looks like linux.md is missing?
5 years, 11 months ago (2015-01-08 18:52:33 UTC) #9
hcm
5 years, 11 months ago (2015-01-08 19:08:03 UTC) #10
Message was sent while issue was closed.
On 2015/01/08 18:52:33, tfarina wrote:
> Looks like linux.md is missing?

Yes, thanks, don't have that one yet but will make sure I get it in the next
batch.

Powered by Google App Engine
This is Rietveld 408576698