device/battery/battery_monitor.mojom - Issue 833983002: Stop using [Client=...] feature of Mojom for BatteryMonitor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/battery/battery_monitor.mojom

Issue 833983002: Stop using [Client=...] feature of Mojom for BatteryMonitor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixup content integration tests Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/battery_status/battery_status_dispatcher.cc ('K') | « device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorImpl.java ('k') | device/battery/battery_monitor_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/battery/battery_monitor.mojom

diff --git a/device/battery/battery_monitor.mojom b/device/battery/battery_monitor.mojom

index 880685e61ca3263039827c1838d55ce742a3bf7b..50202d6f838f0420fe419894a58348692d22a17f 100644

--- a/device/battery/battery_monitor.mojom

+++ b/device/battery/battery_monitor.mojom

@@ -7,10 +7,10 @@ module device;

import "device/battery/battery_status.mojom";

// A BatteryMonitor will periodically call its client's DidChange method.

-[Client=BatteryStatusObserver]

interface BatteryMonitor {

jamesr 2015/01/05 23:33:09 can we get rid of this interface completely? it do

+ SetClient(BatteryMonitorClient client);

};

-interface BatteryStatusObserver {

+interface BatteryMonitorClient {

jamesr 2015/01/05 23:33:09 and just name this BatteryMonitor?

DidChange(BatteryStatus status);

};