device/battery/battery_monitor.mojom - Issue 833983002: Stop using [Client=...] feature of Mojom for BatteryMonitor

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/battery/battery_monitor.mojom

Issue 833983002: Stop using [Client=...] feature of Mojom for BatteryMonitor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixup content integration tests Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/renderer/battery_status/battery_status_dispatcher.cc ('K') | « device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorImpl.java ('k') | device/battery/battery_monitor_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module device;	5 module device;

6	6

7 import "device/battery/battery_status.mojom";	7 import "device/battery/battery_status.mojom";

8	8

9 // A BatteryMonitor will periodically call its client's DidChange method.	9 // A BatteryMonitor will periodically call its client's DidChange method.

10 [Client=BatteryStatusObserver]

11 interface BatteryMonitor {	10 interface BatteryMonitor {
	jamesr 2015/01/05 23:33:09 can we get rid of this interface completely? it do can we get rid of this interface completely? it doesn't add much
	11 SetClient(BatteryMonitorClient client);

12 };	12 };

13	13

14 interface BatteryStatusObserver {	14 interface BatteryMonitorClient {
	jamesr 2015/01/05 23:33:09 and just name this BatteryMonitor? and just name this BatteryMonitor?
15 DidChange(BatteryStatus status);	15 DidChange(BatteryStatus status);

16 };	16 };

OLD	NEW