Stop using [Client=...] feature of Mojom for BatteryMonitor

content/renderer/battery_status/battery_status_dispatcher.cc

Index: content/renderer/battery_status/battery_status_dispatcher.cc
diff --git a/content/renderer/battery_status/battery_status_dispatcher.cc b/content/renderer/battery_status/battery_status_dispatcher.cc
index e7496113d7edd18bc6b9cb7199d605ba21da6af4..5eff04f01d29b76061bda26b8559d7f7ce709ddf 100644
--- a/content/renderer/battery_status/battery_status_dispatcher.cc
+++ b/content/renderer/battery_status/battery_status_dispatcher.cc
@@ -12,11 +12,15 @@ namespace content {
 
 BatteryStatusDispatcher::BatteryStatusDispatcher(
     blink::WebBatteryStatusListener* listener)
-    : listener_(listener) {
+    : binding_(this),
+      listener_(listener) {
   DCHECK(listener_);
 
   RenderThread::Get()->GetServiceRegistry()->ConnectToRemoteService(&monitor_);

[jamesr, 2015/01/05 23:33:09]

i'm not as familiar with content::'s service registry hookup, but it feels weird
to first have this code connect to a named Service only to tell it to set a
client back.  Can we instead just ask the service to connect to us directly and
cut out the Client thingy completely?

In the pure-mojo world, this would work by connecting to the battery monitor
service (by url) and then exposing a monitor interface on the service provider
that's provided to the battery monitor.  so the mojo messages for 'app' to start
listening to battery status updates would be:

app->shell ConnectToApplication("mojo:battery_status", ..)
shell->battery_status_service AcceptConnection(app_url, ...)
battery_status_service->app ConnectToService("device.BatteryMonitor", ...) (via
the mojo.ServiceProvider pipe)
battery_status_service->app DidChange(xxx) (via the device.BatteryMonitor pipe)

-  monitor_.set_client(this);
+
+  device::BatteryMonitorClientPtr proxy;
+  binding_.Bind(&proxy);
+  monitor_->SetClient(proxy.Pass());
 }
 
 BatteryStatusDispatcher::~BatteryStatusDispatcher() {