Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 832713004: Web Animations: Implement the AnimationPlayer finished promise (Closed)

Created:
5 years, 11 months ago by dstockwell
Modified:
5 years, 11 months ago
Reviewers:
haraken, shans
CC:
dstockwell, darktears, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, Inactive, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Web Animations: Implement the AnimationPlayer finished promise Spec: http://w3c.github.io/web-animations/#dom-animationplayer-finished Note: This feature is guarded by the WebAnimationsAPI experimental runtime flag. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188346

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -3 lines) Patch
A LayoutTests/web-animations-api/player-finished-promise.html View 1 2 3 1 chunk +67 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromiseProperties.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/AnimationPlayer.h View 1 2 4 chunks +9 lines, -1 line 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 2 3 5 chunks +30 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationPlayer.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dstockwell
5 years, 11 months ago (2015-01-13 05:28:01 UTC) #2
shans
lgtm
5 years, 11 months ago (2015-01-14 00:10:36 UTC) #3
dstockwell
+haraken for Source/bindings
5 years, 11 months ago (2015-01-14 00:24:33 UTC) #5
haraken
LGTM for bindings/.
5 years, 11 months ago (2015-01-14 00:33:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832713004/60001
5 years, 11 months ago (2015-01-14 00:49:15 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 01:35:17 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188346

Powered by Google App Engine
This is Rietveld 408576698