Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 832393002: Correctly declare skiagm::DCShader to be not flattenable. (Closed)

Created:
5 years, 11 months ago by hal.canary
Modified:
5 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org, bsalomon
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Correctly declare skiagm::DCShader to be not flattenable. Motivation: As part of my testing I serialize all of our GMs to SKP files. This was breaking my code. Committed: https://skia.googlesource.com/skia/+/50b9307e96064637b10b6f070a807e320c45a005

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M gm/dcshader.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
hal.canary
PTAL at this tiny change.
5 years, 11 months ago (2015-01-05 15:32:48 UTC) #2
reed1
lgtm w/ request for comment https://codereview.chromium.org/832393002/diff/1/gm/dcshader.cpp File gm/dcshader.cpp (right): https://codereview.chromium.org/832393002/diff/1/gm/dcshader.cpp#newcode27 gm/dcshader.cpp:27: // We're not flattenable ...
5 years, 11 months ago (2015-01-05 16:27:59 UTC) #3
hal.canary
https://codereview.chromium.org/832393002/diff/1/gm/dcshader.cpp File gm/dcshader.cpp (right): https://codereview.chromium.org/832393002/diff/1/gm/dcshader.cpp#newcode27 gm/dcshader.cpp:27: On 2015/01/05 16:27:59, reed1 wrote: > // We're not ...
5 years, 11 months ago (2015-01-05 16:37:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832393002/20001
5 years, 11 months ago (2015-01-05 16:45:30 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 16:55:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/50b9307e96064637b10b6f070a807e320c45a005

Powered by Google App Engine
This is Rietveld 408576698