content/browser/accessibility/browser_accessibility_manager_android.h - Issue 830943004: Improve the notifications sent from AXTree updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.h

Issue 830943004: Improve the notifications sent from AXTree updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback, add missing call to parent class Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager.cc ('k') | content/browser/accessibility/browser_accessibility_manager_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_android.h

diff --git a/content/browser/accessibility/browser_accessibility_manager_android.h b/content/browser/accessibility/browser_accessibility_manager_android.h

index f0e2d344ac12eb016ed466d877dd37bc8969bd93..3d96d5d4804fead1aaff2e7cf56126cf0c6d1fdb 100644

--- a/content/browser/accessibility/browser_accessibility_manager_android.h

+++ b/content/browser/accessibility/browser_accessibility_manager_android.h

@@ -123,7 +123,9 @@ class CONTENT_EXPORT BrowserAccessibilityManagerAndroid

protected:

// AXTreeDelegate overrides.

- virtual void OnRootChanged(ui::AXNode* new_root) override;

+ void OnAtomicUpdateFinished(

+ bool root_changed,

+ const std::vector<ui::AXTreeDelegate::Change>& changes) override;

virtual bool UseRootScrollOffsetsWhenComputingBounds() override;