Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.cc

Issue 830943004: Improve the notifications sent from AXTree updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback, add missing call to parent class Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_manager_android.cc
diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc
index fd4e0ff9fae105d09adb16902722cef6165da6b3..ef7cd01e824d23db54d0a72d3f7ae4345588cb1c 100644
--- a/content/browser/accessibility/browser_accessibility_manager_android.cc
+++ b/content/browser/accessibility/browser_accessibility_manager_android.cc
@@ -724,13 +724,17 @@ void BrowserAccessibilityManagerAndroid::SetAccessibilityFocus(
delegate_->AccessibilitySetAccessibilityFocus(id);
}
-void BrowserAccessibilityManagerAndroid::OnRootChanged(ui::AXNode* new_root) {
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
- if (obj.is_null())
- return;
-
- Java_BrowserAccessibilityManager_handleNavigate(env, obj.obj());
+void BrowserAccessibilityManagerAndroid::OnAtomicUpdateFinished(
+ bool root_changed,
+ const std::vector<ui::AXTreeDelegate::Change>& changes) {
+ if (root_changed) {
+ JNIEnv* env = AttachCurrentThread();
+ ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
+ if (obj.is_null())
+ return;
+
+ Java_BrowserAccessibilityManager_handleNavigate(env, obj.obj());
+ }
}
bool

Powered by Google App Engine
This is Rietveld 408576698