Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: content/browser/accessibility/browser_accessibility_manager.cc

Issue 830943004: Improve the notifications sent from AXTree updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback, add missing call to parent class Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_manager.cc
diff --git a/content/browser/accessibility/browser_accessibility_manager.cc b/content/browser/accessibility/browser_accessibility_manager.cc
index 7e726bdb09009180812c9c8b26e021ece170381d..52fcc2b1579a0446e2f04416a0576de585e3efba 100644
--- a/content/browser/accessibility/browser_accessibility_manager.cc
+++ b/content/browser/accessibility/browser_accessibility_manager.cc
@@ -185,8 +185,6 @@ void BrowserAccessibilityManager::OnAccessibilityEvents(
}
}
- OnTreeUpdateFinished();
-
if (should_send_initial_focus &&
(!delegate_ || delegate_->AccessibilityViewHasFocus())) {
NotifyAccessibilityEvent(ui::AX_EVENT_FOCUS, GetFromAXNode(focus_));
@@ -415,6 +413,9 @@ void BrowserAccessibilityManager::OnNodeWillBeDeleted(ui::AXNode* node) {
id_wrapper_map_.erase(node->id());
}
+void BrowserAccessibilityManager::OnSubtreeWillBeDeleted(ui::AXNode* node) {
+}
+
void BrowserAccessibilityManager::OnNodeCreated(ui::AXNode* node) {
BrowserAccessibility* wrapper = factory_->Create();
wrapper->Init(this, node);
@@ -426,12 +427,10 @@ void BrowserAccessibilityManager::OnNodeChanged(ui::AXNode* node) {
GetFromAXNode(node)->OnDataChanged();
}
-void BrowserAccessibilityManager::OnNodeCreationFinished(ui::AXNode* node) {
- GetFromAXNode(node)->OnUpdateFinished();
-}
-
-void BrowserAccessibilityManager::OnNodeChangeFinished(ui::AXNode* node) {
- GetFromAXNode(node)->OnUpdateFinished();
+void BrowserAccessibilityManager::OnAtomicUpdateFinished(
+ bool root_changed, const std::vector<ui::AXTreeDelegate::Change>& changes) {
+ for (size_t i = 0; i < changes.size(); ++i)
+ GetFromAXNode(changes[i].node)->OnUpdateFinished();
}
BrowserAccessibilityDelegate*

Powered by Google App Engine
This is Rietveld 408576698