content/browser/accessibility/browser_accessibility_manager_mac.h - Issue 830943004: Improve the notifications sent from AXTree updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_mac.h

Issue 830943004: Improve the notifications sent from AXTree updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback, add missing call to parent class Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/browser_accessibility_manager_mac.h

diff --git a/content/browser/accessibility/browser_accessibility_manager_mac.h b/content/browser/accessibility/browser_accessibility_manager_mac.h

index b754a4b44680170fc0976eb9bd552bd47618a693..02115e8e1f45529e8f294ae34a3cfb70b68596d2 100644

--- a/content/browser/accessibility/browser_accessibility_manager_mac.h

+++ b/content/browser/accessibility/browser_accessibility_manager_mac.h

@@ -31,8 +31,9 @@ class CONTENT_EXPORT BrowserAccessibilityManagerMac

NSView* parent_view() { return parent_view_; }

private:

- void OnNodeCreationFinished(ui::AXNode* node) override;

- void OnTreeUpdateFinished() override;

+ void OnAtomicUpdateFinished(

+ bool root_changed,

+ const std::vector<ui::AXTreeDelegate::Change>& changes) override;

// This gives BrowserAccessibilityManager::Create access to the class

// constructor.

@@ -40,8 +41,6 @@ class CONTENT_EXPORT BrowserAccessibilityManagerMac

NSView* parent_view_;

- bool created_live_region_;

DISALLOW_COPY_AND_ASSIGN(BrowserAccessibilityManagerMac);

};