Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 83083002: Code cleanup: Pass vector by const-ref rather than by value. (Closed)

Created:
7 years, 1 month ago by Ilya Sherman
Modified:
7 years, 1 month ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Code cleanup: Pass vector by const-ref rather than by value. BUG=none TEST=none R=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/autofill/core/browser/personal_data_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ilya Sherman
7 years, 1 month ago (2013-11-22 09:09:13 UTC) #1
Evan Stade
lgtm
7 years, 1 month ago (2013-11-22 21:00:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/83083002/1
7 years, 1 month ago (2013-11-22 22:02:25 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-23 20:57:51 UTC) #4
Message was sent while issue was closed.
Change committed as 236971

Powered by Google App Engine
This is Rietveld 408576698