components/autofill/core/browser/personal_data_manager.h - Issue 83083002: Code cleanup: Pass vector by const-ref rather than by value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/personal_data_manager.h

Issue 83083002: Code cleanup: Pass vector by const-ref rather than by value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/personal_data_manager.h

diff --git a/components/autofill/core/browser/personal_data_manager.h b/components/autofill/core/browser/personal_data_manager.h

index 38da166d4d66efac68976be868f74fc45d2ae92f..537483620217ec11fea47715fbd7daeb81e32672 100644

--- a/components/autofill/core/browser/personal_data_manager.h

+++ b/components/autofill/core/browser/personal_data_manager.h

@@ -141,7 +141,7 @@ class PersonalDataManager : public WebDataServiceConsumer,

const AutofillType& type,

const base::string16& field_contents,

bool field_is_autofilled,

- std::vector<ServerFieldType> other_field_types,

+ const std::vector<ServerFieldType>& other_field_types,

std::vector<base::string16>* values,

std::vector<base::string16>* labels,

std::vector<base::string16>* icons,

« no previous file with comments | « no previous file | components/autofill/core/browser/personal_data_manager.cc » ('j') | no next file with comments »