Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: components/autofill/core/browser/personal_data_manager.h

Issue 83083002: Code cleanup: Pass vector by const-ref rather than by value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | components/autofill/core/browser/personal_data_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 virtual const std::vector<CreditCard*>& GetCreditCards() const; 134 virtual const std::vector<CreditCard*>& GetCreditCards() const;
135 135
136 // Loads profiles that can suggest data for |type|. |field_contents| is the 136 // Loads profiles that can suggest data for |type|. |field_contents| is the
137 // part the user has already typed. |field_is_autofilled| is true if the field 137 // part the user has already typed. |field_is_autofilled| is true if the field
138 // has already been autofilled. |other_field_types| represents the rest of 138 // has already been autofilled. |other_field_types| represents the rest of
139 // form. Identifying info is loaded into the last four outparams. 139 // form. Identifying info is loaded into the last four outparams.
140 void GetProfileSuggestions( 140 void GetProfileSuggestions(
141 const AutofillType& type, 141 const AutofillType& type,
142 const base::string16& field_contents, 142 const base::string16& field_contents,
143 bool field_is_autofilled, 143 bool field_is_autofilled,
144 std::vector<ServerFieldType> other_field_types, 144 const std::vector<ServerFieldType>& other_field_types,
145 std::vector<base::string16>* values, 145 std::vector<base::string16>* values,
146 std::vector<base::string16>* labels, 146 std::vector<base::string16>* labels,
147 std::vector<base::string16>* icons, 147 std::vector<base::string16>* icons,
148 std::vector<GUIDPair>* guid_pairs); 148 std::vector<GUIDPair>* guid_pairs);
149 149
150 // Gets credit cards that can suggest data for |type|. See 150 // Gets credit cards that can suggest data for |type|. See
151 // GetProfileSuggestions for argument descriptions. The variant in each 151 // GetProfileSuggestions for argument descriptions. The variant in each
152 // GUID pair should be ignored. 152 // GUID pair should be ignored.
153 void GetCreditCardSuggestions( 153 void GetCreditCardSuggestions(
154 const AutofillType& type, 154 const AutofillType& type,
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 321
322 // Whether we have already logged the number of profiles this session. 322 // Whether we have already logged the number of profiles this session.
323 mutable bool has_logged_profile_count_; 323 mutable bool has_logged_profile_count_;
324 324
325 DISALLOW_COPY_AND_ASSIGN(PersonalDataManager); 325 DISALLOW_COPY_AND_ASSIGN(PersonalDataManager);
326 }; 326 };
327 327
328 } // namespace autofill 328 } // namespace autofill
329 329
330 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_ 330 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | components/autofill/core/browser/personal_data_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698