Mojo Windows: test_structs.mojom C++ bindings don't compile

Mojo Windows: test_structs.mojom C++ bindings don't compile

See https://codereview.chromium.org/832583002/#msg8

The V10 constant from mojo/public/interfaces/bindings/tests/test_structs.mojom below is the minimum value for an int32.

struct IntegerNumberValues {
  ...
  const int32 V10 = -2147483648;
  ...
}

MSVC can't parse -2147483648, see http://msdn.microsoft.com/en-us/library/4kh09110.aspx

The V10 constant below is the mininum value for an int32.


BUG=445618
R=jimbe@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/cc531b32182099a5a034a99daff35ed5d38a61c8

[hansmuller1, 2014-12-30 20:26:50]

hansmuller@google.com changed reviewers:
+ jimbe@chromium.org

[hansmuller1, 2014-12-30 20:38:51]

hansmuller@google.com changed reviewers:
+ hansmuller@google.com

[hansmuller1, 2014-12-30 20:38:52]

This is a workaround for the problem. I wasn't able to come up with anything
cleverer.

I also fixed a typo in codec_unittests.js. Note sure how that slipped through or
why the waterfall doesn't seem to have been complaining about it.

[jimbe, 2014-12-30 20:49:42]

On 2014/12/30 20:38:52, hansmuller1 wrote:
> This is a workaround for the problem. I wasn't able to come up with anything
> cleverer.
> 
> I also fixed a typo in codec_unittests.js. Note sure how that slipped through
or
> why the waterfall doesn't seem to have been complaining about it.

The definition of INT_MIN in limits.h is (-2147483647 - 1). Can we use that
instead of special casing the values in struct_unittests.js?

[hansmuller1, 2014-12-30 20:51:32]

On 2014/12/30 20:49:42, jimbe wrote:
> On 2014/12/30 20:38:52, hansmuller1 wrote:
> > This is a workaround for the problem. I wasn't able to come up with anything
> > cleverer.
> > 
> > I also fixed a typo in codec_unittests.js. Note sure how that slipped
through
> or
> > why the waterfall doesn't seem to have been complaining about it.
> 
> The definition of INT_MIN in limits.h is (-2147483647 - 1). Can we use that
> instead of special casing the values in struct_unittests.js?

No (although I tried that). Mojom doesn't support constant expressions.

[jimbe, 2014-12-30 21:12:07]

On 2014/12/30 20:51:32, hansmuller1 wrote:
> On 2014/12/30 20:49:42, jimbe wrote:
> > On 2014/12/30 20:38:52, hansmuller1 wrote:
> > > This is a workaround for the problem. I wasn't able to come up with
anything
> > > cleverer.
> > > 
> > > I also fixed a typo in codec_unittests.js. Note sure how that slipped
> through
> > or
> > > why the waterfall doesn't seem to have been complaining about it.
> > 
> > The definition of INT_MIN in limits.h is (-2147483647 - 1). Can we use that
> > instead of special casing the values in struct_unittests.js?
> 
> No (although I tried that). Mojom doesn't support constant expressions.

lgtm. Considering noting in codec.js that some of the tests hardcode an override
for the value because of the bug, so changing that value someday may not fan out
as expected.

[hansmuller, 2014-12-30 21:32:02]

Committed patchset #2 (id:20001) manually as
cc531b32182099a5a034a99daff35ed5d38a61c8 (presubmit successful).