Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: mojo/public/js/struct_unittests.js

Issue 830673002: Mojo Windows: test_structs.mojom C++ bindings don't compile (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Added a comment about tests ignoring V10 Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/js/codec_unittests.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/js/struct_unittests.js
diff --git a/mojo/public/js/struct_unittests.js b/mojo/public/js/struct_unittests.js
index 39a8978139d1c4baa95643fd63567e90e1b07ede..d91ff4d1623bad23de411cc6e74723a04e6c9990 100644
--- a/mojo/public/js/struct_unittests.js
+++ b/mojo/public/js/struct_unittests.js
@@ -189,7 +189,9 @@ define([
}
function testIntegerNumberValues() {
- var decodedStruct = structEncodeDecode(new testStructs.IntegerNumberValues);
+ var minInt32 = -2147483648; // See crbug.com/445618
+ var decodedStruct = structEncodeDecode(
+ new testStructs.IntegerNumberValues({f10: minInt32}));
expect(decodedStruct.f0).toEqual(testStructs.IntegerNumberValues.V0);
expect(decodedStruct.f1).toEqual(testStructs.IntegerNumberValues.V1);
expect(decodedStruct.f2).toEqual(testStructs.IntegerNumberValues.V2);
@@ -200,7 +202,7 @@ define([
expect(decodedStruct.f7).toEqual(testStructs.IntegerNumberValues.V7);
expect(decodedStruct.f8).toEqual(testStructs.IntegerNumberValues.V8);
expect(decodedStruct.f9).toEqual(testStructs.IntegerNumberValues.V9);
- expect(decodedStruct.f10).toEqual(testStructs.IntegerNumberValues.V10);
+ expect(decodedStruct.f10).toEqual(minInt32);
expect(decodedStruct.f11).toEqual(testStructs.IntegerNumberValues.V11);
expect(decodedStruct.f12).toEqual(testStructs.IntegerNumberValues.V12);
expect(decodedStruct.f13).toEqual(testStructs.IntegerNumberValues.V13);
« no previous file with comments | « mojo/public/js/codec_unittests.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698