Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Unified Diff: mojo/public/interfaces/bindings/tests/test_structs.mojom

Issue 830673002: Mojo Windows: test_structs.mojom C++ bindings don't compile (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Added a comment about tests ignoring V10 Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/js/codec_unittests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/interfaces/bindings/tests/test_structs.mojom
diff --git a/mojo/public/interfaces/bindings/tests/test_structs.mojom b/mojo/public/interfaces/bindings/tests/test_structs.mojom
index 40fa9a6bc74616ffa13a6e42368ff77126572e25..490a587c5c2c1786e2c63096f99957360ab8db2a 100644
--- a/mojo/public/interfaces/bindings/tests/test_structs.mojom
+++ b/mojo/public/interfaces/bindings/tests/test_structs.mojom
@@ -183,7 +183,10 @@ struct IntegerNumberValues {
const int16 V8 = 12345;
const int16 V9 = 32767;
- const int32 V10 = -2147483648;
+ // MSVC can't parse -2147483648 so V10 is intentionally off by one.
+ // See http://msdn.microsoft.com/en-us/library/4kh09110.aspx
+ // Tests may override V10.
+ const int32 V10 = -2147483647;
const int32 V11 = -1;
const int32 V12 = 0;
const int32 V13 = 1234567890;
« no previous file with comments | « no previous file | mojo/public/js/codec_unittests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698